Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label initialization #1473

Merged
merged 4 commits into from
Aug 14, 2020
Merged

Fix label initialization #1473

merged 4 commits into from
Aug 14, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Aug 14, 2020

What Changed

Fix getting the prompt value for labels

Why

closes #1461

📦 Published PR as canary version: under canary scope @auto-canary@9.50.9-canary.1473.18249.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.50.9-canary.1473.18249.0
npm install @auto-canary/auto@9.50.9-canary.1473.18249.0
npm install @auto-canary/core@9.50.9-canary.1473.18249.0
npm install @auto-canary/all-contributors@9.50.9-canary.1473.18249.0
npm install @auto-canary/brew@9.50.9-canary.1473.18249.0
npm install @auto-canary/chrome@9.50.9-canary.1473.18249.0
npm install @auto-canary/cocoapods@9.50.9-canary.1473.18249.0
npm install @auto-canary/conventional-commits@9.50.9-canary.1473.18249.0
npm install @auto-canary/crates@9.50.9-canary.1473.18249.0
npm install @auto-canary/exec@9.50.9-canary.1473.18249.0
npm install @auto-canary/first-time-contributor@9.50.9-canary.1473.18249.0
npm install @auto-canary/gem@9.50.9-canary.1473.18249.0
npm install @auto-canary/gh-pages@9.50.9-canary.1473.18249.0
npm install @auto-canary/git-tag@9.50.9-canary.1473.18249.0
npm install @auto-canary/gradle@9.50.9-canary.1473.18249.0
npm install @auto-canary/jira@9.50.9-canary.1473.18249.0
npm install @auto-canary/maven@9.50.9-canary.1473.18249.0
npm install @auto-canary/npm@9.50.9-canary.1473.18249.0
npm install @auto-canary/omit-commits@9.50.9-canary.1473.18249.0
npm install @auto-canary/omit-release-notes@9.50.9-canary.1473.18249.0
npm install @auto-canary/released@9.50.9-canary.1473.18249.0
npm install @auto-canary/s3@9.50.9-canary.1473.18249.0
npm install @auto-canary/slack@9.50.9-canary.1473.18249.0
npm install @auto-canary/twitter@9.50.9-canary.1473.18249.0
npm install @auto-canary/upload-assets@9.50.9-canary.1473.18249.0
# or 
yarn add @auto-canary/bot-list@9.50.9-canary.1473.18249.0
yarn add @auto-canary/auto@9.50.9-canary.1473.18249.0
yarn add @auto-canary/core@9.50.9-canary.1473.18249.0
yarn add @auto-canary/all-contributors@9.50.9-canary.1473.18249.0
yarn add @auto-canary/brew@9.50.9-canary.1473.18249.0
yarn add @auto-canary/chrome@9.50.9-canary.1473.18249.0
yarn add @auto-canary/cocoapods@9.50.9-canary.1473.18249.0
yarn add @auto-canary/conventional-commits@9.50.9-canary.1473.18249.0
yarn add @auto-canary/crates@9.50.9-canary.1473.18249.0
yarn add @auto-canary/exec@9.50.9-canary.1473.18249.0
yarn add @auto-canary/first-time-contributor@9.50.9-canary.1473.18249.0
yarn add @auto-canary/gem@9.50.9-canary.1473.18249.0
yarn add @auto-canary/gh-pages@9.50.9-canary.1473.18249.0
yarn add @auto-canary/git-tag@9.50.9-canary.1473.18249.0
yarn add @auto-canary/gradle@9.50.9-canary.1473.18249.0
yarn add @auto-canary/jira@9.50.9-canary.1473.18249.0
yarn add @auto-canary/maven@9.50.9-canary.1473.18249.0
yarn add @auto-canary/npm@9.50.9-canary.1473.18249.0
yarn add @auto-canary/omit-commits@9.50.9-canary.1473.18249.0
yarn add @auto-canary/omit-release-notes@9.50.9-canary.1473.18249.0
yarn add @auto-canary/released@9.50.9-canary.1473.18249.0
yarn add @auto-canary/s3@9.50.9-canary.1473.18249.0
yarn add @auto-canary/slack@9.50.9-canary.1473.18249.0
yarn add @auto-canary/twitter@9.50.9-canary.1473.18249.0
yarn add @auto-canary/upload-assets@9.50.9-canary.1473.18249.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Aug 14, 2020
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1473 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1473   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files          58       58           
  Lines        4318     4318           
  Branches      961      961           
=======================================
  Hits         3501     3501           
  Misses        571      571           
  Partials      246      246           
Impacted Files Coverage Δ
packages/core/src/init.ts 20.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 834b557...82fec12. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 988d6ca into master Aug 14, 2020
@hipstersmoothie hipstersmoothie deleted the fix-init branch August 14, 2020 19:48
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.50.9 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto init with customizing the default labels sets empty objects
2 participants